Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GUI class #451

Closed
wants to merge 19 commits into from
Closed

Refactor GUI class #451

wants to merge 19 commits into from

Conversation

Raruto
Copy link
Collaborator

@Raruto Raruto commented Jul 20, 2023 •
edited
Loading

Depends on: #450 👉 f14f455

List of changes

  • consolidate all gui code within services/gui.js

  • add several test assertions: console.assert

  • add internal utility function: src/app/core/g3wobject.js::defineClassFields (brings this.setters = {...} support to parent constructor for ES6 classes)

  • start refactoring some (simpler) files in order to make use of native JS classes:

    • convert to ES6 class: src/app/core/g3wobject.js (G3WObject)
    • convert to ES6 class: src/app/core/data/service.js (BaseService)
    • convert to ES6 class: src/app/core/editing/history.js (History)
    • convert to ES6 class: src/app/core/editing/session.js (Session)
    • convert to ES6 class: src/app/core/iframe/services/plugins/service.js (BasePluginService)
    • convert to ES6 class: src/app/core/layers/layersstoresregistry.js (LayersStoresRegistry)
    • convert to ES6 class: src/services/api.js (ApiService)
    • convert to ES6 class: src/services/clipboard.js (ClipboardService)
    • convert to ES6 class: src/services/data-expression.js (ExpressionService)
    • convert to ES6 class: src/services/data-ows.js (OWSService)
    • convert to ES6 class: src/services/data-proxy.js (ProxyService)
    • convert to ES6 class: src/services/data-query.js (QueryService)
    • convert to ES6 class: src/services/data-search.js (SearchService)
    • convert to ES6 class: src/services/data.js (DataService)
    • convert to ES6 class: src/services/editing.js (ChangesManager)
    • convert to ES6 class: src/services/floatbar.js (FloatbarService)
    • convert to ES6 class: src/services/gui.js (GUI)
    • convert to ES6 class: src/services/iframe-app.js (AppService)
    • convert to ES6 class: src/services/iframe-editing.js (EditingService)
    • convert to ES6 class: src/services/iframe-plugin.js (IframePluginService)
    • convert to ES6 class: src/services/navbaritems.js (navbaritemsService)
    • convert to ES6 class: src/services/querybuilder.js (QueryBuilderService)
    • convert to ES6 class: src/services/relations.js (RelationsService)
    • convert to ES6 class: src/services/sidebar.js (SidebarService)
    • convert to ES6 class: src/services/tasks.js (TaskService)
    • convert to ES6 class: src/services/viewport.js (ViewportService)
    • convert to ES6 class: src/services/workflows.js (WorkFlowsStack)
    • convert to ES6 class: src/store/catalog-layers.js (CatalogLayersStoresRegistry)
    • convert to ES6 class: src/store/components.js (ComponentsRegistry)
    • convert to ES6 class: src/store/map-controls.js (ControlsRegistry)
    • convert to ES6 class: src/store/map-layers.js (MapLayersStoresRegistry)
    • convert to ES6 class: src/store/plugins.js (PluginsRegistry)
    • convert to ES6 class: src/store/projects.js (ProjectsRegistry)
    • convert to ES6 class: src/store/sessions.js (SessionsRegistry)

  • remove unusued files

    • delete file: src/app/core/applicationservice.js
    • delete file: src/app/core/map/mapsregistry.js
    • delete file: src/app/core/project/projecttypes.js

Related to: #193 and #291

Raruto added 15 commits July 17, 2023 07:37
@Raruto
consolidate all gui code within services/gui.js
5258584
@Raruto
padding
6c02dcc
@Raruto
Squashed commit of the following:
f14f455 
commit 1269d64
Merge: 65d833f aa0ccd5
Author: Raruto <[email protected]>
Date:   Fri Jul 14 10:52:46 2023 +0200

    Merge branch 'dev' into refactor-inputs-and-fields

commit 65d833f
Merge: e92bc42 c03d8ad
Author: Raruto <[email protected]>
Date:   Thu Jul 13 13:24:26 2023 +0200

    Merge branch 'dev' into refactor-inputs-and-fields

commit e92bc42
Author: Raruto <[email protected]>
Date:   Thu Jul 13 12:41:08 2023 +0200

    Update Relation.vue

commit b538b10
Author: Raruto <[email protected]>
Date:   Wed Jul 12 15:59:41 2023 +0200

    vue warnings

commit 85bf5e8
Author: Raruto <[email protected]>
Date:   Wed Jul 12 08:52:01 2023 +0200

    code format

commit f1c9f4e
Author: Raruto <[email protected]>
Date:   Wed Jul 12 08:51:46 2023 +0200

    update global resize components

commit 2efd115
Author: Raruto <[email protected]>
Date:   Tue Jul 11 12:53:53 2023 +0200

    remove class inheritance: `picklayer`

commit 945d2bf
Author: Raruto <[email protected]>
Date:   Tue Jul 11 11:32:59 2023 +0200

    update `g3w-resize` related components

commit cd0da23
Author: Raruto <[email protected]>
Date:   Mon Jul 10 09:51:41 2023 +0200

    extra comma

commit 2f4ca94
Author: Raruto <[email protected]>
Date:   Mon Jul 10 09:47:38 2023 +0200

    Update form-inputs.js

commit f835618
Author: Raruto <[email protected]>
Date:   Mon Jul 10 09:04:57 2023 +0200

    refactor and delete folder `src/app/gui/fields/`

commit e5e7dc6
Author: Raruto <[email protected]>
Date:   Fri Jul 7 08:57:00 2023 +0200

    comments

commit 6b727da
Author: Raruto <[email protected]>
Date:   Fri Jul 7 08:53:23 2023 +0200

    new factory method: `mixins/g3w-input::createInputService(type, options)`

commit dcc1101
Author: Raruto <[email protected]>
Date:   Fri Jul 7 08:21:32 2023 +0200

    spacing

commit 4455749
Author: Raruto <[email protected]>
Date:   Fri Jul 7 08:18:16 2023 +0200

    spacing

commit 5b7838c
Author: Raruto <[email protected]>
Date:   Fri Jul 7 08:16:49 2023 +0200

    rename file: `mixins/base-inputs.js` --> `mixins/g3w-input.js`

commit 3630da9
Author: Raruto <[email protected]>
Date:   Thu Jul 6 16:25:06 2023 +0200

    template string

commit 5d75dcb
Author: Raruto <[email protected]>
Date:   Thu Jul 6 15:59:49 2023 +0200

    remove `src/app/gui/inputs.js`

commit 9964fa7
Author: Raruto <[email protected]>
Date:   Wed Jul 5 12:53:21 2023 +0200

    Update gulpfile.js

commit d75b466
Author: Raruto <[email protected]>
Date:   Wed Jul 5 12:52:51 2023 +0200

    add `console.assert`

commit 3086d72
Author: Raruto <[email protected]>
Date:   Wed Jul 5 12:10:39 2023 +0200

    spacing

commit 4e3596a
Author: Raruto <[email protected]>
Date:   Wed Jul 5 11:50:11 2023 +0200

    remove parenthesis

commit 3668cb4
Merge: 442bb9d fac0148
Author: Raruto <[email protected]>
Date:   Wed Jul 5 11:45:12 2023 +0200

    Merge branch 'dev' into refactor-inputs

commit 442bb9d
Author: Raruto <[email protected]>
Date:   Wed Jul 5 11:44:38 2023 +0200

    delete folder: `src/app/gui/inputs/`

    starts consolidating all files into a single file: `src/app/gui/inputs.js`
@Raruto
remove internal class: ApplicationTemplate
f843d13
@Raruto
make use of some native JS classes
c2d928d
@Raruto
Update editing.js
ebd5802
@Raruto
convert G3WObject to ES6 class
47cd487
@Raruto
convert GUI to ES6 class
e6681c9
@Raruto
migrate some src/store classes to ES6
12cdfff
@Raruto
convert LayersStoresRegistry to ES6 class
7b34870
@Raruto
convert BasePluginService to ES6 class
625da86
@Raruto
delete unusued files
d88626e
@Raruto
utility function: defineClassField
fe10793
@Raruto
convert some editing classes to ES6
89f93e3
@Raruto
restore gulpfile
9afecbc
@Raruto Raruto added the refactoring Anything which could result in a API change label Jul 20, 2023
@Raruto Raruto added this to the v3.9 milestone Jul 20, 2023
@volterra79 volterra79 modified the milestones: v3.9, v4.0 Nov 6, 2023
@Raruto Raruto mentioned this pull request Jan 22, 2024
Open
@Raruto Raruto mentioned this pull request Feb 19, 2024
Merged
@Raruto Raruto changed the title Refactor GUI and G3WObject classes Refactor GUI ~and G3WObject~ classes Apr 23, 2024
@Raruto Raruto changed the title Refactor GUI ~and G3WObject~ classes Refactor GUI class Apr 23, 2024
@volterra79 volterra79 mentioned this pull request Sep 2, 2024
Merged
@Raruto Raruto closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Raruto Raruto

Labels
refactoring Anything which could result in a API change
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Raruto @volterra79